-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Device Icons for WebOS & Updated Infuse Naming #6281
base: master
Are you sure you want to change the base?
Conversation
Infuse starting in 7.7 uses Infuse-Direct or Infuse-Library depending on the configuration. Adds parsing LG for WebOS.
Used in Dashboard for LG/WebOS Devices.
Cloudflare Pages deployment
|
…yfin for WebOS, and I included Swiftfin both when it was Jellyfin XXX and Swiftfin XXX.
I'm sorry about that! I think I have this resolved. Additionally, while I was looking at my devices I realized Swiftfin wasn't in there on web for Apple either! So I've added both variants of Swiftfin. It looks like 1.0.1 and below is just Jellyfin tvOS/iOS/iPadOS and 1.1+ is Swiftfin tvOS/iOS/iPadOS. Additionally, I put the client name in for LG TV since it looks like we're looking at both client and device. Let me know if this scaling looks right! I added some items next to it for comparison: |
Oh! Lastly, the Samsung.svg should be Samsungtv.svg. I updated that too. |
Quality Gate passedIssues Measures |
Changes
First time doing anything on Web so please let me know if this isn't right!
Over in Swiftfin, I added Device Logos and I threw in a webOS (LG TVs) icon as well. I just wanted to add that logo and the logic so Jellyfin-Web had it as well. In my testing, 'LG Smart TV' covers all of the TVs (all 2 I had to test) but I'm unsure if there is a different name for projectors?
I am using webOS's icon from here: https://en.wikipedia.org/wiki/WebOS#/media/File:LG_WebOS_New.svg.
Additionally, during my Swiftfin changes, I found that Infuse doesn't use 'Infuse' as a device name after 7.7(?) and now uses 'Infuse-Direct' or 'Infuse-Library' on later versions. While I was adding WebOS, I added this change as well. I left the original just plain 'Infuse' for anyone running previous versions as well.
Issues
#6280